Branch/afrin#99
Merged
Merged
Conversation
…less of source The earlier fix (b7ade35) only recognized a dependency as already installed if its jar hash matched a Modrinth-hosted file. A dependency installed via CurseForge, or placed manually, has a different hash and slipped straight through, still showing up as Required/Optional even though it was already in the mods folder. Added a second, network-free check: read the mod id directly out of each installed jar's own metadata (fabric.mod.json/quilt.mod.json/ mods.toml/mcmod.info) and cross-reference it against each dependency's Modrinth slug. Matches are dropped from the dialog entirely rather than left unchecked, and if nothing's left to prompt for, the dialog is skipped and the mod downloads directly. Also added a User-Agent header and timeouts to ApiHandler's raw GET/POST calls, since a silently failing or hanging Modrinth request would make the original hash-based filter fall back to nothing installed too.
…& Manage Content Replace Browse Mods / Manage Mods with a content-type picker that lets you browse or manage mods, resource packs, or shader packs through the same search/install/update pipeline. Introduces a ContentType enum carrying folder name, file extension, and Modrinth/CurseForge search parameters per kind. Relocates the per-instance version/loader filter from a button inside Manage Mods to the Manage Content picker, since it's shared across all three content types rather than mod-specific. The loader half of that filter is now ignored for resource packs and shader packs everywhere (search, dependency install, update checks), and auto-fills from the instance's own version/loader the first time it's opened. InstalledModAdapter generalized from hardcoded .jar scanning to any ContentType's extension; icon/name extraction already degraded gracefully for non-mod content so needed no changes there.
Browse Content and Manage Content's + search button previously opened unfiltered until the user manually opened the filter dialog and hit Apply. Both now fall back to the instance's own detected version/loader (same InstanceVersionResolver logic the filter dialog already uses) when no filter has been saved yet, so results are relevant immediately. Also fixed the Browse/Manage Content picker dialog's corners looking mismatched — the layout draws its own rounded card, but the dialog window's default background was still showing through behind it. Window background is now transparent so only the card's rounded corners show.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.