Skip to content

Branch/afrin#99

Merged
MaxJubayerYT merged 3 commits into
v3_openjdkfrom
branch/Afrin
Jul 11, 2026
Merged

Branch/afrin#99
MaxJubayerYT merged 3 commits into
v3_openjdkfrom
branch/Afrin

Conversation

@MaxJubayerYT

Copy link
Copy Markdown
Member

No description provided.

…less of source

The earlier fix (b7ade35) only recognized a dependency as already
installed if its jar hash matched a Modrinth-hosted file. A dependency
installed via CurseForge, or placed manually, has a different hash and
slipped straight through, still showing up as Required/Optional even
though it was already in the mods folder.

Added a second, network-free check: read the mod id directly out of
each installed jar's own metadata (fabric.mod.json/quilt.mod.json/
mods.toml/mcmod.info) and cross-reference it against each dependency's
Modrinth slug. Matches are dropped from the dialog entirely rather than
left unchecked, and if nothing's left to prompt for, the dialog is
skipped and the mod downloads directly.

Also added a User-Agent header and timeouts to ApiHandler's raw GET/POST
calls, since a silently failing or hanging Modrinth request would make
the original hash-based filter fall back to nothing installed too.
…& Manage Content

Replace Browse Mods / Manage Mods with a content-type picker that lets you browse or manage mods,
resource packs, or shader packs through the same search/install/update
pipeline. Introduces a ContentType enum carrying folder name, file
extension, and Modrinth/CurseForge search parameters per kind.

Relocates the per-instance version/loader filter from a button inside
Manage Mods to the Manage Content picker, since it's shared across all
three content types rather than mod-specific. The loader half of that
filter is now ignored for resource packs and shader packs everywhere
(search, dependency install, update checks), and auto-fills from the
instance's own version/loader the first time it's opened.

InstalledModAdapter generalized from hardcoded .jar scanning to any
ContentType's extension; icon/name extraction already degraded
gracefully for non-mod content so needed no changes there.
Browse Content and Manage Content's + search button previously opened
unfiltered until the user manually opened the filter dialog and hit
Apply. Both now fall back to the instance's own detected version/loader
(same InstanceVersionResolver logic the filter dialog already uses) when
no filter has been saved yet, so results are relevant immediately.

Also fixed the Browse/Manage Content picker dialog's corners looking
mismatched — the layout draws its own rounded card, but the dialog
window's default background was still showing through behind it. Window
background is now transparent so only the card's rounded corners show.
@MaxJubayerYT MaxJubayerYT merged commit 500b4fd into v3_openjdk Jul 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant